Review Request 127771: KTp qml applet tooltip improvements.

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127771/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 3:18 p.m.)


Review request for Telepathy.


Changes
-------

1) Rebase for #124875 changes.
2) Remove hasEnabledAccountsChanged, requestedPresenceChanged, isChangingPresence signal triggers.
3) Use currentPresence instead of requestedPresence.


Repository: ktp-desktop-applets


Description
-------

1)Show the presence message in the tooltip if there is one.
2)Indicate if there are no accounts online in the tooltip.
3)Fix the tooltip showing the wrong state, e.g. Connecting... when connected, changing presence to available... when available.
4)Hide the actions that require an account to be connected when there are no accounts connected.


Diffs (updated)
-----

  contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8ebeef8c018450719fba3ac06e42434e326 

Diff: https://git.reviewboard.kde.org/r/127771/diff/


Testing (updated)
-------

Compile, run.

Tooltips can sometimes show the wrong information because of a property ordering bug in tp-qt <= 0.9.7. https://bugs.freedesktop.org/show_bug.cgi?id=92153


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20161214/325a6b3b/attachment.html>