Review Request 127189: ktp-contact-list offline-on-close fix.

James Smith smithjd15 at gmail.com
Fri Dec 2 22:31:47 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127189/
-----------------------------------------------------------

(Updated Dec. 2, 2016, 3:31 p.m.)


Review request for Telepathy.


Changes
-------

Update for removing isAnyAccountOnline() and goOffline() in #123487.


Repository: ktp-contact-list


Description (updated)
-------

Fixes offline-on-close.

The check for qApp->closingDown() doesn't appear required, and removing it is needed for the global presence to change offline on close.

This applies to #123487, which removes goOffline() and isAnyAccountOnline() and integrates KTp::GlobalPresence in MainWidget.


Diffs (updated)
-----

  main-widget.cpp e0982594ac4c05b84db5772722b98b733410752b 

Diff: https://git.reviewboard.kde.org/r/127189/diff/


Testing (updated)
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20161202/089587b2/attachment.html>


More information about the KDE-Telepathy mailing list