Review Request 128774: ktp-text-ui: Added a filter to show info about linked github issue or pull request (WIP)

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128774/
-----------------------------------------------------------

(Updated Aug. 26, 2016, 11:19 p.m.)


Review request for Telepathy.


Changes
-------

Forgot to say "thanks!" to bugzilla authors for the escapeHTML() function.


Repository: ktp-text-ui


Description (updated)
-------

!Not intended to be shipped yet!
Preview of a new filter, which works similar to bugzilla. The filter shows issue info retrieved for github via API.
There is some known issues with the filter, but I would like to share it early to get your valueable reviews :)
I would like to discuss:
- Is it appropriate name? This filter can be extended to support gitlab and may be more providers later.
- What do you think about format of the info?

I thought on it and I should say that this filter has nothing in share with "bugzilla" filter. Except the purpose. :)

P.S. Thanks to the bugzilla plugin for the escapeHTML() function.


Diffs
-----

  filters/CMakeLists.txt ce06ba7 
  filters/github/CMakeLists.txt PRE-CREATION 
  filters/github/github-filter.h PRE-CREATION 
  filters/github/github-filter.cpp PRE-CREATION 
  filters/github/ktptextui_message_filter_github.desktop.cmake PRE-CREATION 
  filters/github/showGithubInfo.js PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128774/diff/


Testing
-------

Does not work reliably yet.


File Attachments
----------------

Filter in action
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/c171785f-3e77-4517-a32b-1a134504da77__out2.gif


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160826/eb4c22ec/attachment.html>