Review Request 128460: ktp-text-ui: Added a filter for geo uri support

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128460/
-----------------------------------------------------------

(Updated Aug. 7, 2016, 2:28 a.m.)


Review request for Telepathy.


Changes
-------

Removed checks for string to number conversions. It is pointless, because of regular expression.
Previously proposed code is broken, because it doesn't increase index (which leads to infinity loop).


Repository: ktp-text-ui


Description
-------

Added a geopoint filter which adds an iframe with a map for each geo:<double,double> in message (RFC 5870).
Uses OpenStreetMap as "backend".


Diffs (updated)
-----

  filters/CMakeLists.txt 8118b13 
  filters/geopoint/CMakeLists.txt PRE-CREATION 
  filters/geopoint/geopoint-filter.h PRE-CREATION 
  filters/geopoint/geopoint-filter.cpp PRE-CREATION 
  filters/geopoint/ktptextui_message_filter_geopoint.desktop.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128460/diff/


Testing
-------

It works for me.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160806/352e556d/attachment-0001.html>