Review Request 128561: port salut plugin to kf5

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128561/#review98107
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks good, I'm unsure why this is not working, TBH.
I'd say merge it in and then we can look into figuring out why isn't signond finding the provider.


data/kaccounts/ktp-salut.provider.in (line 5)
<https://git.reviewboard.kde.org/r/128561/#comment66075>

    Remove trailing spaces


- Aleix Pol Gonzalez


On July 31, 2016, 1:28 a.m., Björn Bidar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128561/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 1:28 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> port salut plugin to kf5
> 
> 
> Diffs
> -----
> 
>   data/kaccounts/ktp-salut-im.service.in PRE-CREATION 
>   data/kaccounts/ktp-salut.provider.in PRE-CREATION 
>   plugins/CMakeLists.txt db9bfc458cf1bb9e06d0402d6a03b6c320fbcc3e 
>   plugins/salut/CMakeLists.txt 32a428e8237ee15053255a7f51bf7059abe4c33e 
>   plugins/salut/salut-account-ui-plugin.cpp 79c969a86c9fc27b873fcc04eefb9842ec260918 
>   plugins/salut/salut-advanced-options-widget.ui 9b05f768be1d855221b4941e99b6fbcd0cc4dcae 
>   plugins/salut/salut-main-options-widget.ui 75d74e3497dc03f65675de1bbbacdc041447536f 
> 
> Diff: https://git.reviewboard.kde.org/r/128561/diff/
> 
> 
> Testing
> -------
> 
> I ported the plugin to mimic the changes made to the other plugins, however I get the message that the handler for this protocoll isn't installed althrough it is.
> Need some help on this.
> 
> 
> Thanks,
> 
> Björn Bidar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160804/c5471356/attachment.html>