Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/#review94413
-----------------------------------------------------------


Fix it, then Ship it!





config/telepathy-kded-config.cpp (line 216)
<https://git.reviewboard.kde.org/r/123504/#comment64187>

    and here



telepathy-mpris.cpp (line 104)
<https://git.reviewboard.kde.org/r/123504/#comment64186>

    In English that makes it sound like the other person is physically playing the song with guitars and stuff.
    
    listening is the better verb to describe what the _person_ is doing which is what you want in your status message.


- David Edmundson


On March 7, 2016, 6:52 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123504/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 6:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> New features:
> -Much improved multiple player handling; a number of service availability bugs were fixed.
> -Default template changed from 'Now Listening to ...'  to 'Now Playing ...'
> -Ignore tracks with inadequate metadata
> -Separator for empty metadata info fields with (currently) hidden config
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
> 
> Diff: https://git.reviewboard.kde.org/r/123504/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160407/45f6f9d7/attachment.html>