Review Request 123482: ktp-common-internals status handler integration and global / multiple account presence fixes

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123482/
-----------------------------------------------------------

(Updated April 4, 2016, 4:20 a.m.)


Review request for Telepathy.


Changes
-------

StatusHandlerPresence:
1) New presenceQueueActive, statusMessageQueueActive properties.
2) Removed requestedGlobalPresenceChanged signal.
3) Removed mixedPresenceMode.
4) A large number of changes to remove value caching.
5) Copyright header clarification, class description changes, commenting changes.

GlobalPresence:
1) Remove statusMessageQueueActiveChanged(), presenceQueueActiveChanged() signals.
2) New autoPresenceActiveChanged() signal.
3) activeQueuePlugin() -> autoPresenceActive().
4) mixedPresenceMode -> globalPresenceMode.
5) Remove globalRequestedPresence.
6) Connect to the DBus interface without using StatusHandlerPresence.


Repository: ktp-common-internals


Description
-------

New classes:
-StatusHandlerPresence, an interface for StatusHandler PluginQueue and AccountStatusHelper DBus interfaces, and a number of control functions for the Presence / StatusMessageInserter plugins (per-app save / restore presence replacement).

New properties:
-GlobalPresence: bool activeAutoPresence(), bool mixedPresenceMode(), KTp::Presence globalRequestedPresence().

New methods:
-GlobalPresence: onAccountDisabled(Tp::AccountPtr)

New types:
KTp::PluginQueue, for indicating the state of the plugin queue plugins, e.g. PluginDisabledOnLoad, PluginDisabled, PluginEnabled, PluginActive, etc.

New features:
-pluginQueue active / inactive information in GlobalPresence, separate presenceQueueActiveChanged and statusMessageQueueActiveChanged signals.
-More reliable global property signalling.
-Reworked account enable / disable.
-Presence priority improvements.

Other simple cleanups (Use KTp::Presence where possible, make function arguments conform, commenting clarifications, errant properties, etc.)


Diffs (updated)
-----

  KTp/CMakeLists.txt 85d578bc3cbc0ae5769e6ff9f466381da4e701a7 
  KTp/Declarative/qml-plugins.cpp 4956a1c94fe60a526367f6a74a357d510e74e519 
  KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 
  KTp/global-presence.h 46e6cc358b0f3cdaff35d3a7be25949646b400d3 
  KTp/global-presence.cpp 8f1148b4ec339ab77f9c2fca0c87429ac14c5194 
  KTp/presence.h 7da07d0120c75ed057f4b2f2f832f5a1f80bd528 
  KTp/presence.cpp 6030db0ed821a4399603b5453ab124c741912a1f 
  KTp/status-handler-presence.h PRE-CREATION 
  KTp/status-handler-presence.cpp PRE-CREATION 
  KTp/types.h 27eb8975a4149e78c1e545b7273572c7eb18bad3 

Diff: https://git.reviewboard.kde.org/r/123482/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160404/859b6eac/attachment.html>