Review Request 125242: Add option to disable keyboard layout switching

[David Rosca]

> On Sept. 16, 2015, 1:04 p.m., David Edmundson wrote:
> > >It is disabled by default now, because it breaks "per-app layout switching" of kcm_keyboard and also is a feature that may be confusing for users.
> > 
> > Yeah, it seems like a nice idea, but maybe we need to redesign it properly adding the relevant code to keyboard switcher and not just working around it.

This works on tabs, so it can't be implemented in kded keyboard switcher, because it only knows about windows.

It should be fixed to don't break "per-app layout switching" option though, but that doesn't seem trivial. There was a commit that tried to fix it, but it actually only fixed one issue where it breaks kded keyboard switcher.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125242/#review85494
-----------------------------------------------------------


On Sept. 16, 2015, 1:50 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125242/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 1:50 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Remembering keyboard layout per tab can now be disabled in settings.
> 
> It is disabled by default now, because it breaks "per-app layout switching" of kcm_keyboard and also is a feature that may be confusing for users.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp de07445 
>   config/behavior/behavior-config.h 389d3c8 
>   config/behavior/behavior-config.cpp c02863f 
>   config/behavior/behavior-config.ui 44c0aa6 
>   lib/text-chat-config.h a02dee6 
>   lib/text-chat-config.cpp 5cf5f6e 
> 
> Diff: https://git.reviewboard.kde.org/r/125242/diff/
> 
> 
> Testing
> -------
> 
> Disabling it works
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150916/526a7fe4/attachment-0001.html>