Review Request 125146: Call parent ::event()
Albert Astals Cid
aacid at kde.org
Fri Sep 11 12:34:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125146/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 12:34 p.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy and Martin Klapetek.
Changes
-------
Submitted with commit 42cf29d56ccf3b107f7f063f3ae36d269aa44d30 by Albert Astals Cid to branch Applications/15.08.
Repository: ktp-text-ui
Description
-------
::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work
In this case it probably doesn't matter, but it's always good to have "good code"
Diffs
-----
lib/chat-search-bar.cpp f0a559f
Diff: https://git.reviewboard.kde.org/r/125146/diff/
Testing
-------
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150911/4e078866/attachment.html>
More information about the KDE-Telepathy
mailing list