Review Request 125103: BUG 345446: log-viewer shows "There are no logs for this day"

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125103/#review85010
-----------------------------------------------------------


Thanks for the patch

Is there a chance you can try this on 15.08? The thing is that we're not going to release any more qt4 versions, so I'm afraid this patch will just never get out...

- Martin Klapetek


On Sept. 8, 2015, 1:19 p.m., Alexandre Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125103/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 1:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 345446
>     http://bugs.kde.org/show_bug.cgi?id=345446
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> ktp-log-viewer: unable to read logs
> 
> This is due to function "PendingEvents::Private::storeAndFreeEvent" ( project: telepathy-logger-qt4, file: TelepathyLoggerQt4/pending-events.cpp) that push TextEvent into a list of event that made a staticCast too.
> 
> ----- code snip -----
> TextEventPtr eventPtr = TextEventPtr::wrap(TPL_TEXT_EVENT(tplEvent), true);
> self->mPriv->events << eventPtr;
> ---------------------
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp 69e342677dc747b419c18e4372b555ab4dfa0a48 
> 
> Diff: https://git.reviewboard.kde.org/r/125103/diff/
> 
> 
> Testing
> -------
> 
> I run under FreeBSD with version 0.8.0, but I'm able to see log in both log-viewer and chat window.
> 
> 
> Thanks,
> 
> Alexandre Martins
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150908/c7709f0d/attachment.html>