Review Request 125008: Reenable tts-filter and make it use QtSpeech instead of dying KSpeech api.

Jeremy Whiting jpwhiting at kde.org
Tue Sep 1 01:46:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125008/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 7:46 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Removed -DHAVE_SPEECH since we don't use it anyway.


Repository: ktp-text-ui


Description
-------

Also made it build by adding the #include "tts-filter.moc", I guess it's been disabled for a little while.


Diffs (updated)
-----

  CMakeLists.txt e88f6faabfddf9480a080cae8bf23c34994b92d7 
  filters/CMakeLists.txt 52b3a790c632b2d53b670aa8d7c4d396cf89f475 
  filters/texttospeech/CMakeLists.txt f3aaff84cafc321ae8c0a633c2c7bdfea8a4bdd8 
  filters/texttospeech/tts-filter.cpp bb9c7a5cf0f9174f6041c64f2a7d84ecfcb3f9e7 

Diff: https://git.reviewboard.kde.org/r/125008/diff/


Testing
-------

It builds. I didn't go to the point of setting up a telepathy account to test this with just yet, but will if the code looks ok.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150901/4252f79f/attachment-0001.html>


More information about the KDE-Telepathy mailing list