Review Request 125780: Relicense invalid license to LGPL 2.1+

Diane Trout diane at ghic.org
Sat Oct 24 18:59:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125780/
-----------------------------------------------------------

Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

Scott Kitterman noticed the license for this code was
"GPL 2.1+" which doesn't exist.

I (Diane Trout) tried to contact the author on a few occasions but
did not see a response.

I believe this code was created as a Google Summer of Code project and
so the following criteria which states that the student needs to choose
a license approved by the mentoring organization.

http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2015/help_page?PageSpeed=noscript#2._What_licenses_do_I_have_to_choose

The most likely thing is that the original license block is a
typo and the student had first written GPL-3, but then changed it to
GPL 2.1, but forgot to add the "Lesser".

In an ideal world the student Marcin Ziemi?ski would approve this.


Diffs
-----

  otr-proxy/KTpProxy/main.cpp 87e1df6b20df098f75916e13837f38d5a00dfba7 
  otr-proxy/KTpProxy/otr-config.h ce42c00cfb37774494888f722f6766288d45d78a 
  otr-proxy/KTpProxy/otr-config.cpp 28c316c4ef79be6b286121991477c86e34b14720 
  otr-proxy/KTpProxy/otr-constants.h 08f1a14f821583832e2e44e87449d241be7014f3 
  otr-proxy/KTpProxy/otr-manager.h b8807aa6b61c94e968dc931a2188065fb3b972c3 
  otr-proxy/KTpProxy/otr-manager.cpp 6cbdfdffa48fbceb213140300d1b1ac684e2c57e 
  otr-proxy/KTpProxy/otr-message.h cd46f07676934e6c425436c3a96060e30b70f77e 
  otr-proxy/KTpProxy/otr-message.cpp d475f40c28d5d10ed4f20c9397dd8bb9afbd949f 
  otr-proxy/KTpProxy/otr-proxy-channel-adaptee.h 78fd81b73deb450b13dc559c439c3c39010ce9fa 
  otr-proxy/KTpProxy/otr-proxy-channel-adaptee.cpp e30167f7512deaac50c7d3c136cfab496b5188b6 
  otr-proxy/KTpProxy/otr-proxy-channel.h daefe67c24979bbc61ef5f15d462f9b48c674895 
  otr-proxy/KTpProxy/otr-proxy-channel.cpp 025bebc2f465717ee6d8610763801848356d6f59 
  otr-proxy/KTpProxy/otr-session.h de1b3819d5dda1753000d3ceb96b7d17fbbca94f 
  otr-proxy/KTpProxy/otr-session.cpp 60c169f2661c56e6b5b737d8098d9354def643d8 
  otr-proxy/KTpProxy/otr-utils.h fd80d146b324f674fef7be8b6c68f0bc4280a164 
  otr-proxy/KTpProxy/otr-utils.cpp 4b506221bfbdf8a46e3524fdba23d007ce5906fd 
  otr-proxy/KTpProxy/pending-curry-operation.h 80e3fcc009f66fe0eb5809c553bde669baa874d1 
  otr-proxy/KTpProxy/pending-curry-operation.cpp f5eee49269fc885c0db7660db6e3f5774a833b62 
  otr-proxy/KTpProxy/proxy-observer.h 5b37e021ab2c2e11c044ab914985d28c3712f6c0 
  otr-proxy/KTpProxy/proxy-observer.cpp f8c715d908f8c9bf2dde4dd477ce6dd32440dd00 
  otr-proxy/KTpProxy/proxy-service-adaptee.h 25b5e1e3e1b01ad976b40dded5e1a40393fabbce 
  otr-proxy/KTpProxy/proxy-service-adaptee.cpp 509349dc3fcb76519f0f945b33833c8b6c3fc422 
  otr-proxy/KTpProxy/proxy-service.h 31f5e58f17418d288f42aaa3d51ef91823c11fbe 
  otr-proxy/KTpProxy/proxy-service.cpp b5e68b15025f4a6fd0b8cf17547c58ee326af949 
  otr-proxy/KTpProxy/types.h deee1b6d30895b81ff197212d2f001a2336f6d87 
  otr-proxy/test/otr-test.cpp 5979e102632e0e23373f6ed654b8580ca1cf5b6d 

Diff: https://git.reviewboard.kde.org/r/125780/diff/


Testing
-------

Ran licensecheck -cr * | grep -v LGPL and made sure there was no GPL license still around.


Thanks,

Diane Trout

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151024/57184f26/attachment.html>


More information about the KDE-Telepathy mailing list