Review Request 123915: Use custom PushButton to draw contents aligned to left

[David Rosca]

> On May 27, 2015, 11:44 a.m., Martin Klapetek wrote:
> > Good start; while we're doing our own control, can we get the label vertically center aligned with the icon? --> https://dl.dropboxusercontent.com/u/6761102/kaccounts_buttons.png
> 
> David Rosca wrote:
>     I can't reproduce it, can you please tell me what fonts and sizes are you using? Also, this should be fixed in Breeze.
> 
> Martin Klapetek wrote:
>     Oxygen 9; it's not just Breeze though, it's also in Oxygen and Fusion, see https://dl.dropboxusercontent.com/u/6761102/kaccounts_buttons_oxygen.png and https://dl.dropboxusercontent.com/u/6761102/kaccounts_buttons_fusion.png
>     
>     (breeze and oxygen are from latest master)

Hmm, still can't reproduce .. I assume the issue is only with this custom button and not all push buttons, right?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123915/#review80888
-----------------------------------------------------------


On May 27, 2015, 12:30 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123915/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 12:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> The custom button uses same paint code as QCommonStyle, but it sets width of the rect to width of icon and text when drawing CE_PushButtonLabel which forces the contents to be left aligned.
> 
> 
> Diffs
> -----
> 
>   src/create.cpp 49ce1bd 
> 
> Diff: https://git.reviewboard.kde.org/r/123915/diff/
> 
> 
> Testing
> -------
> 
> Button contents are now left aligned, same as with QCommandLinkButton. Tested with Breeze, Oxygen, Fusion, win9x and GTK+ Oxygen styles.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150527/c68c2a13/attachment.html>