Review Request 123893: Add option to use different emoticons for each account

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123893/#review80791
-----------------------------------------------------------

Ship it!


...as long as there is a way to easily turn all the custom ones off. The UI should probably go to the emoticons filter settings window (there currently isn't any). Ideally it should be a list with "Add custom set for account" and "Remove all" buttons.

- Martin Klapetek


On May 24, 2015, 4:56 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123893/
> -----------------------------------------------------------
> 
> (Updated May 24, 2015, 4:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332183
>     http://bugs.kde.org/show_bug.cgi?id=332183
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> The name of emoticon theme for account is stored in ktelepathyrc and then used by ktp-text-ui.
> If there is no specified emoticon theme, the default emoticon theme is used.
> 
> This needs UI somewhere in settings to configure the emoticons for each account. I'm not sure where to put it (in kaccounts-kcm?), so suggestions welcome.
> 
> 
> Diffs
> -----
> 
>   app/emoticon-text-edit-action.h a5ae531 
>   app/emoticon-text-edit-action.cpp 2ee628e 
>   app/emoticon-text-edit-selector.h fb1584f 
>   app/emoticon-text-edit-selector.cpp 22742fb 
>   filters/emoticons/CMakeLists.txt 447b223 
>   filters/emoticons/emoticon-filter.h 0f5a1ec 
>   filters/emoticons/emoticon-filter.cpp 565ae84 
>   lib/CMakeLists.txt d6af848 
>   lib/emoticons-manager.h PRE-CREATION 
>   lib/emoticons-manager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123893/diff/
> 
> 
> Testing
> -------
> 
> Works fine
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150525/4e2d48ac/attachment.html>