Review Request 123185: Add support for "Connect and start chat" action into kpeople actions + use the new KPeople action types

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 30 17:04:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123185/
-----------------------------------------------------------

(Updated March 30, 2015, 5:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Eike Hein.


Changes
-------

Submitted with commit 0b5d45d855ffed8cef991b5687971cdbeeea6e8f by Martin Klapetek to branch master.


Repository: ktp-common-internals


Description
-------

When the contact is offline, special action is returned which will first connect the account and then start the chat.

This is done for text chat only as there is no way of knowing if the target contact has a support for audio/video calls before it's connected, while text chats will work in 98% of the cases.


Diffs
-----

  kpeople/actionsplugin/CMakeLists.txt f0f4dd5 
  kpeople/actionsplugin/kpeople-actions-plugin.h b80bef8 
  kpeople/actionsplugin/kpeople-actions-plugin.cpp d065840 

Diff: https://git.reviewboard.kde.org/r/123185/diff/


Testing
-------

Went offline, selected the action from contact list's context menu, everything worked as expected.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150330/3eaf9001/attachment.html>


More information about the KDE-Telepathy mailing list