Review Request 123184: Add enum for ActionsType (+ fix documentation)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123184/#review78223
-----------------------------------------------------------



src/persondata.h (line 52)
<https://git.reviewboard.kde.org/r/123184/#comment53596>

    Shouldn't this go with src/widgets/actions.h?


If the host application is required to check for a property, then this should be documented as well.

I'm unsure about the use-case there though. Why do we need to filter the actions? If we just want chat, wouldn't it be better to directly request it to KTp?

- Aleix Pol Gonzalez


On March 30, 2015, 5:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123184/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 5:03 p.m.)
> 
> 
> Review request for Telepathy and Eike Hein.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Some clients need/want to filter actions based on types, this adds the actions enum with currently known actions. Plugins returning QList<QAction*> should then use this enum to set the appropriate type on the action (via setProperty).
> 
> I've put it to PersonData because all code dealing with actions currently need to include PersonData header and I'm not sure if it makes sense anywhere else.
> 
> 
> Diffs
> -----
> 
>   src/persondata.h c3f99a9 
>   src/widgets/actions.h 2931ef8 
> 
> Diff: https://git.reviewboard.kde.org/r/123184/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150330/d1f4b79a/attachment.html>