Review Request 123185: Add support for "Connect and start chat" action into kpeople actions + use the new KPeople action types

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123185/#review78224
-----------------------------------------------------------



kpeople/actionsplugin/kpeople-actions-plugin.cpp (line 188)
<https://git.reviewboard.kde.org/r/123185/#comment53597>

    Hmm ... if you have an IMAction constructor with a type parameter and what not, why is this using QAction and doing the rest manually?


- Eike Hein


On March 30, 2015, 3:31 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123185/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 3:31 p.m.)
> 
> 
> Review request for Telepathy and Eike Hein.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> When the contact is offline, special action is returned which will first connect the account and then start the chat.
> 
> This is done for text chat only as there is no way of knowing if the target contact has a support for audio/video calls before it's connected, while text chats will work in 98% of the cases.
> 
> 
> Diffs
> -----
> 
>   kpeople/actionsplugin/kpeople-actions-plugin.h b80bef8 
>   kpeople/actionsplugin/kpeople-actions-plugin.cpp d065840 
> 
> Diff: https://git.reviewboard.kde.org/r/123185/diff/
> 
> 
> Testing
> -------
> 
> Went offline, selected the action from contact list's context menu, everything worked as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150330/67b76dfa/attachment.html>