Review Request 123060: Port away from KIcon

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 23 11:27:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123060/#review77962
-----------------------------------------------------------

Ship it!


The IconSize is not exactly the solution to the hidpi problem, that would require qApp->setAttribute(Qt::AA_useHighDPIPixmaps); in main.cpp and running with QT_DEVICE_PIXEL_RATIO=2 and see how it looks, but as none of the ktp apps actually are hidpi compliant, this shouldn't be holded back for it, but feel free to add it and check anyway

- Martin Klapetek


On March 20, 2015, 8:22 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123060/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Port away from KIcon
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 873dd93eba18e046b20d89a16d4c843f31377a22 
>   src/CMakeLists.txt 3cb382648243129a2126cd546059786a4f1fbc77 
>   src/status-area.cpp b8a36d3855ee9ab67a8e3ad6107e9e3615a41148 
> 
> Diff: https://git.reviewboard.kde.org/r/123060/diff/
> 
> 
> Testing
> -------
> 
> Builds, video call work.
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150323/d6906116/attachment.html>


More information about the KDE-Telepathy mailing list