Review Request 123087: Port away from kDebug / kWarning / kError

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123087/#review77955
-----------------------------------------------------------

Ship it!


I just noticed you have two ktp_call_ui_debug.*, that's fine although I'd suggest to make one "ktp-call-ui" and the other one "libcallui", it doesn't make sense if both the lib and app have the same debug namespace.

- Martin Klapetek


On March 21, 2015, 7:38 a.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123087/
> -----------------------------------------------------------
> 
> (Updated March 21, 2015, 7:38 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Port away from kDebug / kWarning / kError
> 
> 
> Diffs
> -----
> 
>   libktpcall/CMakeLists.txt 512c9f1476636487bd3165bc599d0ca703c62398 
>   libktpcall/call-channel-handler.cpp 8779b602028b6812892b5c1a8fb01300781eee7a 
>   libktpcall/call-content-handler.cpp d167835693d6429da11f7f55cd99af92ba7e0d5d 
>   libktpcall/ktp_call_ui_debug.h PRE-CREATION 
>   libktpcall/ktp_call_ui_debug.cpp PRE-CREATION 
>   libktpcall/private/device-element-factory.cpp 2d425003a98f87cf45695220bbddf6eb15ffa4c2 
>   libktpcall/private/phonon-integration.cpp ece6a8b63020ae23cdff202c32942843ed46aa6c 
>   libktpcall/private/sink-controllers.cpp 7ed56139feda9cc73a7366a771ebf63f0aa278bf 
>   libktpcall/private/sink-manager.cpp 1df1c1734d4616bbb15e0cd90a34dad428ef9bde 
>   libktpcall/private/tf-audio-content-handler.cpp 965c19ce2ff057430298d4c4aca5a83d6e7641f3 
>   libktpcall/private/tf-channel-handler.cpp 9d906c571e16323dc8bf8b26b77bad864556ba19 
>   libktpcall/private/tf-content-handler.cpp a8456e2ccce20ea3076cdd97c21ccf2c5e37c898 
>   libktpcall/private/tf-video-content-handler.cpp a8a9eca2a8eb88bb3140643f66529d410bc7087c 
>   libktpcall/private/video-sink-bin.cpp 0b95b5c4a4cb30d4aca4ad93cc940f47bb5d9769 
>   libktpcall/tests/CMakeLists.txt f0377cc5f5873624a62714922284ab1c8375876c 
>   libktpcall/tests/configuration_test.cpp 6b5da6b0e325cda0509a35b862071424807f8cd9 
>   src/CMakeLists.txt 3cb382648243129a2126cd546059786a4f1fbc77 
>   src/approver.cpp cab426b7f1241190bb3bfa1b0062aea9e06be8b6 
>   src/call-handler.cpp 75c798491058e0bdd29b0a7618baf86b17048f5c 
>   src/call-manager.cpp df6e7017f9fb6248c5e5488eb45f7c891d18aa0f 
>   src/call-window.cpp b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4 
>   src/dialout/CMakeLists.txt 242fc2b9691875bf8b285c61849d7c9c7dd6e396 
>   src/dialout/dialout-widget.cpp 2cf5e7f28519f573a3eac1587bc0034a602c46b4 
>   src/ktp_call_ui_debug.h PRE-CREATION 
>   src/ktp_call_ui_debug.cpp PRE-CREATION 
>   src/status-area.cpp b8a36d3855ee9ab67a8e3ad6107e9e3615a41148 
> 
> Diff: https://git.reviewboard.kde.org/r/123087/diff/
> 
> 
> Testing
> -------
> 
> Builds, starts.
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150323/ef1de060/attachment.html>