Review Request 123071: There is no setSoundEnabled slot

[Diane Trout]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123071/#review77894
-----------------------------------------------------------

Ship it!


I wasn't really sure what Kaditx was trying to do with both setsound and mute. Theoretically there should eventually be a UI element to change the volume.

- Diane Trout


On March 19, 2015, 12:20 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123071/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 12:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> There is no setSoundEnabled slot
> 
> 
> Diffs
> -----
> 
>   src/call-window.cpp b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4 
> 
> Diff: https://git.reviewboard.kde.org/r/123071/diff/
> 
> 
> Testing
> -------
> 
> Builds, video calls work.
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150321/6e1a3aeb/attachment.html>