Review Request 123062: Port away from KUniqueApplication, K4AboutData, ...

Martin Klapetek martin.klapetek at gmail.com
Thu Mar 19 20:26:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123062/#review77754
-----------------------------------------------------------



src/dialout/main.cpp
<https://git.reviewboard.kde.org/r/123062/#comment53346>

    This should probably be "...Dialout Ui"? Same in the KAboutData actually...?



src/dialout/main.cpp
<https://git.reviewboard.kde.org/r/123062/#comment53347>

    Can you do "if(" -> "if (" if you're already touching that line?


- Martin Klapetek


On March 19, 2015, 8:10 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123062/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 8:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Port away from KUniqueApplication, K4AboutData, ...
> 
> 
> Diffs
> -----
> 
>   src/dialout/main.cpp 32f0b88323bfc8dc67d91cd96d471b11f18323aa 
> 
> Diff: https://git.reviewboard.kde.org/r/123062/diff/
> 
> 
> Testing
> -------
> 
> Builds, starts.
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150319/ead58e1f/attachment.html>


More information about the KDE-Telepathy mailing list