Review Request 122924: Workaround bug with "per window" keyboard layout switching

[Martin Klapetek]

> On March 16, 2015, 11:31 a.m., Martin Klapetek wrote:
> > Thanks for the patch
> > 
> > However it is quite some workaround. Let's actually find out if the bug is indeed in kwin and if it is, let's have it fixed in kwin. Working around things is bad, especially with timers.
> > 
> > So I assume this is for master (and thus kf5 versions) and that the steps you described in the bug report are still valid for the kf5 version, correct?
> 
> Eugene Shalygin wrote:
>     Well, fast switching between the chat window and another app makes it (the bug) happen for me in less than a minute. Yes, it happens with Plasma 5. 
>     I guess if one runs another WM and the bug disappears, this will be a clear indication of KWin misbehaviour?
>     
>     I absolutetly understand your position on workarounds and timers. I'm just sick of this problem...
> 
> Martin Klapetek wrote:
>     I understand, sorry about that, we're now very short on manpower. I'll talk to Martin G, the kwin guy, and see what we can come up with.
>     
>     And yeah you can try running openbox ($ openbox --replace &) and see if the behavior changes.
> 
> Eugene Shalygin wrote:
>     OK. A bit of information for Martin: only check whether the chat window is active, without the delay, does not help. Only delay, without the check, seems to decrease the rate of incrorrect layout switches, but does not eliminate them.
> 
> Martin Klapetek wrote:
>     Martin says this has nothing to do with kwin ("given I've never heard about this feature it probably doesn't"). So I'll have a proper look at how things work.
> 
> Eugene Shalygin wrote:
>     Hm. Who sends QEvent::WindowActivate event then?

X server, I'd guess. Basically WM tells X "this window is now active" and X makes it active and Qt detects it through its xcb plugin and sends proper events. I think.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122924/#review77560
-----------------------------------------------------------


On March 12, 2015, 8:13 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122924/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 8:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 333742
>     http://bugs.kde.org/show_bug.cgi?id=333742
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This must have be a bug in KWin. I believe it is sending window activation events when it shall not. As a result, layout switch is requested when another application is active and affects it, and this is very annoing. So, here we workaround this by waiting 200 ms and then checking is the chat windows still active.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 0d1e0bb 
>   app/chat-window.cpp de07445 
> 
> Diff: https://git.reviewboard.kde.org/r/122924/diff/
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150316/e73e7ad9/attachment-0001.html>