Review Request 122924: Workaround bug with "per window" keyboard layout switching

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122924/#review77560
-----------------------------------------------------------


Thanks for the patch

However it is quite some workaround. Let's actually find out if the bug is indeed in kwin and if it is, let's have it fixed in kwin. Working around things is bad, especially with timers.

So I assume this is for master (and thus kf5 versions) and that the steps you described in the bug report are still valid for the kf5 version, correct?

- Martin Klapetek


On March 12, 2015, 8:13 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122924/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 8:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 333742
>     http://bugs.kde.org/show_bug.cgi?id=333742
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This must have be a bug in KWin. I believe it is sending window activation events when it shall not. As a result, layout switch is requested when another application is active and affects it, and this is very annoing. So, here we workaround this by waiting 200 ms and then checking is the chat windows still active.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 0d1e0bb 
>   app/chat-window.cpp de07445 
> 
> Diff: https://git.reviewboard.kde.org/r/122924/diff/
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150316/d46e7704/attachment.html>