Review Request 121302: Add a small delay to global presence and message changes

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121302/
-----------------------------------------------------------

(Updated March 6, 2015, 11:52 a.m.)


Review request for Telepathy.


Changes
-------

Make the activation timer a fully-fledged timer object. Connect the plugin activation signals to the timer object directly.


Repository: ktp-kded-module


Description
-------

This fixes a few minor presence output glitches in open chats with presence change monitoring enabled, for example the now playing plugin can look inactive briefly, instead of changing to the next track without a user presence in between. Also both presence plugins disable on inactivity, and instead of a single change to the intended presence, both plugins deactivate with presence changes until the desired presence is finally reached. With this patch only one de-activation presence change is performed. Also advantageous is the presence change limiting effect, for example a media player can effect a number of rapid presence changes by the now Playing plugin, and a means to limit or skip undesired presence changing during rapid track advancement should IMO already have been built into how the presence change is effected.


Diffs (updated)
-----

  status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
  status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 

Diff: https://git.reviewboard.kde.org/r/121302/diff/


Testing
-------

None.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150306/96c2bbf1/attachment.html>