Review Request 122778: Show full text

[Martin Klapetek]

> On March 3, 2015, 4:25 p.m., Martin Klapetek wrote:
> > "Show Contact Information..."
> > 
> > ...and ship to master
> 
> Aleix Pol Gonzalez wrote:
>     Why add Contact? It's a context menu, and the context is the contact, no?

Because we use "Contact" everywhere else in the menu, "Re-request Contact Authorization", "Resend Contact Authorization", "Remove Contact...", "Block Contact..." etc. So it makes sense to put it there too if we're changing it already.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122778/#review76952
-----------------------------------------------------------


On March 2, 2015, 5:42 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122778/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 5:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> There's no real gain by shortening Information into Info.
> 
> 
> Diffs
> -----
> 
>   context-menu.cpp 2870aad 
> 
> Diff: https://git.reviewboard.kde.org/r/122778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150304/aca3f165/attachment.html>