Review Request 124137: Make it possible to access OnlineAccounts using QtQuick

[Martin Klapetek]

> On June 22, 2015, 7:14 a.m., David Edmundson wrote:
> > Seems odd to use a mix of Ubuntu's imports and our stuff.
> > Does their import not cover creating accounts? Probably worth exporting our model too, so apps don't have to import two things.
> 
> Aleix Pol Gonzalez wrote:
>     It's only weird because they branded the QML module (and so we do). OTOH, they developped the rest of the stuff and it's part of the stack.
>     
>     https://gitlab.com/accounts-sso/accounts-qml-module

It'd be better to use our own models, indeed, but we only actually have one. The rest are lists done on the fly. This was done back in the days and there was no need to change that so I left it as lists+foreach. At some point this should be changed and we should reuse our own tech in the imports rather than having two imports, that will require more substantial changes to everything though. So for now this will do.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124137/#review81643
-----------------------------------------------------------


On June 22, 2015, 8:01 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124137/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 8:01 a.m.)
> 
> 
> Review request for KDEPIM and Telepathy.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> Adds a plugin and an example that uses it. Seems to work.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7431dba 
>   example/accounts.qml PRE-CREATION 
>   src/CMakeLists.txt f28ebb6 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
>   src/jobs/createaccount.h c9d23b6 
>   src/jobs/createaccount.cpp 883283f 
> 
> Diff: https://git.reviewboard.kde.org/r/124137/diff/
> 
> 
> Testing
> -------
> 
> Played around with the example.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150622/68f41659/attachment.html>