Review Request 124137: Make it possible to access OnlineAccounts using QtQuick

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124137/#review81650
-----------------------------------------------------------

Ship it!


What may be a, possibly minor, issue is that this advertises "qml support", however all the UI plugins are currently qwidgets-based only and there's no detection done to prevent loading non-qml plugins. At some point there should be "if (qml) { load_plugins_for_qml } else { load_plugins_for_widgets } plus it should probably also filter providers which it can create from a qml only environment (providers have <plugin> entry).


example/accounts.qml (line 22)
<https://git.reviewboard.kde.org/r/124137/#comment55963>

    This should be "Add new Account"



example/accounts.qml (line 47)
<https://git.reviewboard.kde.org/r/124137/#comment55964>

    "Available Accounts"



src/declarative/kaccountsdeclarativeplugin.h (lines 26 - 27)
<https://git.reviewboard.kde.org/r/124137/#comment55965>

    One tab too many


- Martin Klapetek


On June 22, 2015, 8:01 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124137/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 8:01 a.m.)
> 
> 
> Review request for KDEPIM and Telepathy.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> Adds a plugin and an example that uses it. Seems to work.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7431dba 
>   example/accounts.qml PRE-CREATION 
>   src/CMakeLists.txt f28ebb6 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
>   src/jobs/createaccount.h c9d23b6 
>   src/jobs/createaccount.cpp 883283f 
> 
> Diff: https://git.reviewboard.kde.org/r/124137/diff/
> 
> 
> Testing
> -------
> 
> Played around with the example.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150622/4b4742ca/attachment-0001.html>