Review Request 114574: KeepAwake plugin for KTp

[Martin Klapetek]

> On July 11, 2015, 11:55 p.m., Aleix Pol Gonzalez wrote:
> > Controlling the system's powermanagement profile with KTp state doesn't sound very logical to me.
> > I could agree that being able to specify you're in front of the computer could be cool, but this doesn't seem to be the way. :/
> 
> James Smith wrote:
>     Mostly useful is that it doesn't shut down when the IM presence specifically requires an operational KTp,the IM presence for the most part being conscienciously set anyway. This closely matches the behaviour of watching a movie or listening to a music track which is also a consciencious action, and also inhibits power suspension.
> 
> Aleix Pol Gonzalez wrote:
>     I didn't say it's not useful, I said it's not obvious.
>     
>     It's not the kind of behaviour to expect.

As I said before - no. I do not want to be online on KTp and having burned my laptop in my bag because it won't suspend when I close the lid. And I sure don't want to manually set myself to offline every time I need to put my laptop to sleep.

If you willingly want to suppress suspend, Plasma has a checkbox made exactly for these cases. There is no point in duplicating the checkbox here.

I will not accept this patch, sorry.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114574/#review82367
-----------------------------------------------------------


On July 11, 2015, 10:45 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114574/
> -----------------------------------------------------------
> 
> (Updated July 11, 2015, 10:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> KeepAwake plugin inhibits suspend for certain IM states. Also adds infrastructure for presence-responsive plugins.
> 
> 
> Diffs
> -----
> 
>   keepawake.cpp PRE-CREATION 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-module.cpp 3c34b6e5e0364334c962b4df0dffc70cffed91bc 
>   config/telepathy-kded-config.cpp a4b890ce05c35f58c8a446b8fc8151727f174355 
>   config/telepathy-kded-config.ui 93c06dc74b4dcb37e0473d0debfb5e738a24afa9 
>   keepawake.h PRE-CREATION 
>   CMakeLists.txt a5317b480f2013a1c227c1c7f2da85cad13a64b3 
>   config/telepathy-kded-config.h 0400626f205468b1ac9c6964d96a9644ceec32c3 
> 
> Diff: https://git.reviewboard.kde.org/r/114574/diff/
> 
> 
> Testing
> -------
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150731/72c4f9be/attachment-0001.html>