Review Request 123893: Add option to use different emoticons for each account

Martin Klapetek martin.klapetek at gmail.com
Mon Jul 13 22:55:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123893/#review82478
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On June 16, 2015, 12:29 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123893/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 12:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332183
>     http://bugs.kde.org/show_bug.cgi?id=332183
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> The name of emoticon theme for account is stored in ktp-text-uirc under Filter-Emoticons group.
> If there is no specified emoticon theme, the default emoticon theme is used.
> 
> The ui to set the emoticons is accessible from emoticons filter plugin settings.
> 
> 
> Diffs
> -----
> 
>   app/emoticon-text-edit-action.h a5ae531 
>   app/emoticon-text-edit-action.cpp 2ee628e 
>   app/emoticon-text-edit-selector.h fb1584f 
>   app/emoticon-text-edit-selector.cpp 22742fb 
>   filters/emoticons/CMakeLists.txt 447b223 
>   filters/emoticons/emoticon-config.h PRE-CREATION 
>   filters/emoticons/emoticon-config.cpp PRE-CREATION 
>   filters/emoticons/emoticon-config.ui PRE-CREATION 
>   filters/emoticons/emoticon-filter.h 0f5a1ec 
>   filters/emoticons/emoticon-filter.cpp 565ae84 
>   filters/emoticons/kcm_ktptextui_message_filter_emoticons.desktop PRE-CREATION 
>   lib/CMakeLists.txt d6af848 
>   lib/emoticons-manager.h PRE-CREATION 
>   lib/emoticons-manager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123893/diff/
> 
> 
> Testing
> -------
> 
> Works fine
> 
> 
> File Attachments
> ----------------
> 
> add-account-dialog.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/25/38ee6d38-e1cc-4f7e-ae5f-59fb8a926560__add-account-dialog.png
> settings-dialog.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/26/5a6c6874-d956-4880-b65f-82972d211967__settings-dialog.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150713/4ce0eb43/attachment.html>


More information about the KDE-Telepathy mailing list