Review Request 124310: Improve quick chat widget

[Aleix Pol Gonzalez]

> On July 9, 2015, 8:37 p.m., Martin Klapetek wrote:
> > Can you also have a look at https://bugs.kde.org/show_bug.cgi?id=298306 and perhaps include the fix for that as well?
> > 
> > Basically the chat applet should collapse when it has nothing to show, just like eg. desktop pager or system tray.

The fix for this bug should end up somewhere else in the code, so it should be another review. Also I looked into the code and I'm not sure that the bug is entirely in the plasmoid or in plasma-framework.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124310/#review82292
-----------------------------------------------------------


On July 9, 2015, 8:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124310/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:03 p.m.)
> 
> 
> Review request for Plasma and Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This improves the chat widget by:
> - Not hardcoding the hader size
> - Using a heading for the name so it stands out a bit more (since it's often not obvious at a glance who you're writing to)
> - Giving it a proper scroll bar
> - Making the auto scrolling a bit more robust
> - Cleaing up the code a bit
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124310/diff/
> 
> 
> Testing
> -------
> 
> Been using it for a while, works nicely and looks better
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150709/5329a76f/attachment.html>