Review Request 122188: [TelpathyLoggerQt] Port to ECM

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122188/#review74494
-----------------------------------------------------------

Ship it!



TelepathyLoggerQt/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122188/#comment51663>

    Maybe put this in TpQtMacros? Or better, TpLoggerQtMacros?
    Ot better, create a generate_headers_with_dashes in ECM. ;)
    
    One of those...


Other than that, it looks good to me.

- Aleix Pol Gonzalez


On Jan. 21, 2015, 7:58 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122188/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 7:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: telepathy-logger-qt
> 
> 
> Description
> -------
> 
> Port TelepathyLoggerQt to ECM. It makes the buildsystem much simpler and actually maintainable.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/Qt5Macros.cmake e7eb0cb 
>   cmake/modules/QtMacros.cmake 9f8f998 
>   cmake/modules/TelepathyDefaults.cmake b926246 
>   cmake/modules/TelepathyDist.cmake 8d6fadd 
>   TelepathyLoggerQt/pending-entities.h 325c9fb 
>   TelepathyLoggerQt/pending-entities.cpp 7b3f0a8 
>   TelepathyLoggerQt/pending-events.h a87c884 
>   TelepathyLoggerQt/pending-events.cpp 143f609 
>   TelepathyLoggerQt/pending-log-walker-operation.h 531a37d 
>   TelepathyLoggerQt/pending-log-walker-operation.cpp 46f82e4 
>   TelepathyLoggerQt/pending-operation.h d48d941 
>   TelepathyLoggerQt/pending-operation.cpp da302f3 
>   TelepathyLoggerQt/pending-search.h ab4b246 
>   TelepathyLoggerQt/pending-search.cpp db3076e 
>   TelepathyLoggerQt/search-hit.h f12d694 
>   TelepathyLoggerQt/search-hit.cpp 50ab25f 
>   TelepathyLoggerQt/text-event.h 0a9d410 
>   TelepathyLoggerQt/text-event.cpp ea5be41 
>   TelepathyLoggerQt/types.h 3670075 
>   TelepathyLoggerQt/utils.h 378fb23 
>   TelepathyLoggerQt/utils.cpp e39b494 
>   cmake/modules/BasicFindPackageVersion.cmake.in 2be6d9e 
>   cmake/modules/InstallSettings.cmake b8a79bb 
>   cmake/modules/MacroWriteBasicCMakeVersionFile.cmake d23d857 
>   TelepathyLoggerQt/call-event.cpp fd3a3ec 
>   TelepathyLoggerQt/entity.h 2a2520a 
>   TelepathyLoggerQt/entity.cpp 8c37893 
>   TelepathyLoggerQt/event.h 96c275a 
>   TelepathyLoggerQt/event.cpp 15c1ae1 
>   TelepathyLoggerQt/global.h 491861f 
>   TelepathyLoggerQt/init.h 6848539 
>   TelepathyLoggerQt/init.cpp 7e925b3 
>   TelepathyLoggerQt/log-manager.h 3679660 
>   TelepathyLoggerQt/log-manager.cpp b113d4d 
>   TelepathyLoggerQt/log-walker.h a2ef313 
>   TelepathyLoggerQt/log-walker.cpp 7add228 
>   TelepathyLoggerQt/object.h 4f140b1 
>   TelepathyLoggerQt/pending-clear.h 75c88bd 
>   TelepathyLoggerQt/pending-clear.cpp e26c719 
>   TelepathyLoggerQt/pending-dates.h ba2772b 
>   TelepathyLoggerQt/pending-dates.cpp d690c3c 
>   CMakeLists.txt eeab518 
>   TelepathyLoggerQt/CMakeLists.txt 8c84f29 
>   TelepathyLoggerQt/CallEvent ddac7fb 
>   TelepathyLoggerQt/Entity 4f1f0b7 
>   TelepathyLoggerQt/Event 2a0e8ed 
>   TelepathyLoggerQt/Global ecf1d7d 
>   TelepathyLoggerQt/Init f8a2430 
>   TelepathyLoggerQt/LogManager 580cf87 
>   TelepathyLoggerQt/LogWalker bd2a0fe 
>   TelepathyLoggerQt/Object 3dd41b2 
>   TelepathyLoggerQt/PendingDates 46ffe6e 
>   TelepathyLoggerQt/PendingEntities 7007da7 
>   TelepathyLoggerQt/PendingEvents df4c775 
>   TelepathyLoggerQt/PendingOperation 5521ac5 
>   TelepathyLoggerQt/PendingSearch 7b38788 
>   TelepathyLoggerQt/SearchHit f05782e 
>   TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in ca7f0cc 
>   TelepathyLoggerQt/TextEvent 98072c1 
>   TelepathyLoggerQt/Types 471c141 
>   TelepathyLoggerQt/call-event.h e820a2e 
> 
> Diff: https://git.reviewboard.kde.org/r/122188/diff/
> 
> 
> Testing
> -------
> 
> Built TpLoggerQt with this patch, built k-c-i against it, tried accessing logs from ktp-log-viewer...and it worked!
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150121/7e3feea2/attachment-0001.html>