Review Request 122006: Manually access dtmf D-Bus interface.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122006/#review74037
-----------------------------------------------------------

Ship it!


Looks good, my knowledge in that area is zarro but I trust your testing.

- Martin Klapetek


On Jan. 12, 2015, 6:32 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122006/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 6:32 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> CallContact::supportsDTMF didn't work for me so try to directly access
> to the D-Bus interface pointer.
> 
> 
> Diffs
> -----
> 
>   src/call-window.cpp 6a6e7892288b2143923b488ae3a59da8f3f01268 
>   src/dtmf-handler.cpp 0c56b7374ca0e79d71f114328a39f63d674f9e5a 
> 
> Diff: https://git.reviewboard.kde.org/r/122006/diff/
> 
> 
> Testing
> -------
> 
> Called thetestcall at iptel.org and pushed dtmf buttons. for whatever reason the list of D-Bus Interfaces for the CallContentPtr is always empty.
> 
> This technique worked.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150114/a7601fd8/attachment.html>