Review Request 121639: Split out KF5Contacts dependency

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jan 7 14:39:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121639/
-----------------------------------------------------------

(Updated Jan. 7, 2015, 2:39 p.m.)


Review request for KDEPIM, Telepathy, Christian Mollekopf, David Edmundson, and Martin Klapetek.


Changes
-------

Solved some of the issues pointed out by David and MartinK.


Repository: libkpeople


Description
-------

Last week we had a couple of discussions regarding KPeople relationship with KDE PIM and KContacts and we agreed that we want to keep KContacts as a framework that is good at dealing with vCards, which leaves KPeople without a good way to send around its data.

This patch proposes an internal AbstractContact class that the backends will have to re-implement. At the moment it only requires a "customProperty" that lets us fetch whatever is needed.
Furthermore, it also includes a set of convenience methods in PersonData to have a type-safe API.


Diffs (updated)
-----

  src/widgets/persondetailsview.cpp b7535bd 

Diff: https://git.reviewboard.kde.org/r/121639/diff/


Testing
-------

Builds, the test passes. ktp tests work, somewhat.
Also there's few tests altogether.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150107/e339514b/attachment.html>


More information about the KDE-Telepathy mailing list