Review Request 121877: Add option for setting ignore-tls-errors in rakia plugin.

[Diane Trout]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121877/
-----------------------------------------------------------

Review request for Telepathy.


Repository: ktp-accounts-kcm


Description
-------

Add option for setting ignore-tls-errors in rakia plugin.


Diffs
-----

  plugins/rakia/rakia-advanced-options-widget.ui 460d8398930be96dddb7dd0db4eadeeb97d824ca 
  plugins/rakia/rakia-advanced-options-widget.cpp 673fbccae51eed104b0dc21e4692c5d98bdfdfb7 

Diff: https://git.reviewboard.kde.org/r/121877/diff/


Testing
-------

Launched kcm using LD_LIBRARY_PATH=$(pwd) kcmshell4  kcm_ktp_accounts

1) verified the option appeared in the settings panel.
2) removed my manually added certificate so sofia wouldn't find it.
3) tried to connect. verified it failed.
4) turned option on verified connection succeeded.

(or maybe I swapped the order of 3 & 4, it doesn't matter that much)

The one downside is I did the testing against the 0.9 branch as I don't have a KF5 environment setup yet.

The other downside is the string is a new string. the gabble uses the term "Ignore SSL Errors" which is somewhat obsolete.


Thanks,

Diane Trout

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150106/9d0abce9/attachment.html>