Review Request 121823: Disable now Playing config widgets when now Playing is unchecked

[Martin Klapetek]

> On Jan. 5, 2015, 3:10 p.m., Martin Klapetek wrote:
> > This broke the build, can we get a fix please?
> > 
> > http://build.kde.org/job/ktp-kded-module_master_qt5/75/console
> 
> Martin Klapetek wrote:
>     I've reverted this now. Please make sure you test it before pushing.
> 
> David Edmundson wrote:
>     I'm the one who pushed without checking.
>     
>     James wrote depends on 121387 in RB, I didn't see it.
> 
> James Smith wrote:
>     Do you want to take the whole depends now? There are a ton of new features inc. multiple player improvements, configureable video metadata, configureable empty field placeholder, etc. and a few bugfixes. The only thing that didn't recieve at least run-testing is the video mime lookup for frameworks which drops back to the audio now Playing if there isn't a video mimetype. Otherwise I'm reasonably confident in its current state.

We're starting to duplicate Plasma5 mediaplayer applet/dataengine here, I think we should really investigate if we can reuse the data directly from there, maybe even put "set as my IM status" checkbox in there, rather than coding the same thing again.

Personally I would prefer if the whole mpris integration in ktp would just die with frameworks.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121823/#review73163
-----------------------------------------------------------


On Jan. 6, 2015, 1:02 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121823/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 1:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Disable the now Playing group box widgets when enable now Playing is unchecked.This is similar to what autoaway and screensaver away do with their widgets when disabled.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 9c686d1ca54c277e4ef5cfe95232a150f6ea102b 
> 
> Diff: https://git.reviewboard.kde.org/r/121823/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> File Attachments
> ----------------
> 
> Disabled widgets screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/05/aa64cc40-f52f-4f24-b8fe-2819ec0f38f7__nowplayinggroupboxdisabledwidgets.png
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150106/03cabe43/attachment.html>