Review Request 121823: Disable now Playing config widgets when now Playing is unchecked

David Edmundson david at davidedmundson.co.uk
Mon Jan 5 23:42:12 UTC 2015



> On Jan. 5, 2015, 2:10 p.m., Martin Klapetek wrote:
> > This broke the build, can we get a fix please?
> > 
> > http://build.kde.org/job/ktp-kded-module_master_qt5/75/console
> 
> Martin Klapetek wrote:
>     I've reverted this now. Please make sure you test it before pushing.

I'm the one who pushed without checking.

James wrote depends on 121387 in RB, I didn't see it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121823/#review73163
-----------------------------------------------------------


On Jan. 5, 2015, 11:22 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121823/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 11:22 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Disable the now Playing group box widgets when enable now Playing is unchecked.This is similar to what autoaway and screensaver away do with their widgets when disabled.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 9c686d1ca54c277e4ef5cfe95232a150f6ea102b 
> 
> Diff: https://git.reviewboard.kde.org/r/121823/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150105/2f14ef59/attachment.html>


More information about the KDE-Telepathy mailing list