Review Request 121844: Fix requested / current presence change to emit only one signal

James Smith smithjd15 at gmail.com
Mon Jan 5 10:33:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121844/#review73128
-----------------------------------------------------------


Should this be applied to 0.9 branch?

- James Smith


On Jan. 5, 2015, 10:33 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121844/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 10:33 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 334492 and 334542
>     http://bugs.kde.org/show_bug.cgi?id=334492
>     http://bugs.kde.org/show_bug.cgi?id=334542
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Only emit one presence change instead of one for each account. This prevents late returns (e.g. network-related) and duplicate presence change events from accounts disrupting the global presence, and may prevent a particular nasty disk / state bug that affects the kded module plugins.
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.cpp 08e268b78991a57f0f37b0b3b78a257a7e8a0c18 
> 
> Diff: https://git.reviewboard.kde.org/r/121844/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150105/6ad9f905/attachment-0001.html>


More information about the KDE-Telepathy mailing list