Review Request 121843: Fix several QML UI issues in ktp-call-ui

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121843/#review73106
-----------------------------------------------------------


+1 Looks good to me, maybe I missed something, never read that code-base.

- Aleix Pol Gonzalez


On Jan. 5, 2015, 12:55 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121843/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 12:55 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> call-window.cpp: Properly use rootObject for attaching signals between C++ & QML.
>   Connect showDtmfAction signal to toggleDtmf.
> ToggleButton.qml: use root.checked instead of non-existant function root.activate
> Fix doubled // in pathname.
> 
> 
> Diffs
> -----
> 
>   src/call-window.cpp 6edaced29e61625d4146bf0a93073c3e21febc5c 
>   src/qml/core/ToggleButton.qml 8ca1e6517a3b422232564ddbf265c8e571582679 
>   src/qml/core/Toolbar.qml 18fb3fc908f3590a754c8e08aa0092ef141b81e9 
> 
> Diff: https://git.reviewboard.kde.org/r/121843/diff/
> 
> 
> Testing
> -------
> 
> Built ktp-call-ui (with another set of changes to support detecting if dtmf is working) and called a couple of sip test numbers music at iptel.org and thetestcall at iptel.org to try the hold, mute, and dtmf buttons.
> 
> The Icons couple probably be better. It would be nice if the mute button toggled between showing sound lines & nothing, and the use of a phone icon to represent the dialpad was non obvious when I showed the UI to someone else in my house.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150105/daefc54e/attachment.html>