Review Request 122729: Drop Baloo things

[Martin Klapetek]

> On Feb. 26, 2015, 5:26 p.m., Vishesh Handa wrote:
> > I don't like throwing away the code, but it will require significant work before it works again.

Yeah...and I think it will be better/easier to start fresh then trying to bend it to the reworked code.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122729/#review76675
-----------------------------------------------------------


On Feb. 26, 2015, 4:55 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122729/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 4:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Quoting Vishesh "it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs."
> 
> 
> Diffs
> -----
> 
>   src/widgets/personemailview.h 1f9e862 
>   src/widgets/personemailview.cpp eda0a25 
>   src/widgets/plugins/emaillistmodel.h 9430929 
>   src/widgets/plugins/emaillistmodel.cpp a83bc96 
>   src/widgets/plugins/emaillistviewdelegate.h 43c111f 
>   src/widgets/plugins/emaillistviewdelegate.cpp ba6d29e 
>   src/widgets/plugins/emails.h 45df621 
>   src/widgets/plugins/emails.cpp dede2d1 
>   CMakeLists.txt 0e17cf6 
>   src/widgets/CMakeLists.txt 213c6bf 
> 
> Diff: https://git.reviewboard.kde.org/r/122729/diff/
> 
> 
> Testing
> -------
> 
> It builds fine
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150226/969e8ca1/attachment.html>