Review Request 122692: Move the OTR config module from ktp-text-ui to here
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Feb 23 16:19:31 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122692/#review76479
-----------------------------------------------------------
+1 LGTM
- Aleix Pol Gonzalez
On Feb. 23, 2015, 5:08 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122692/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 5:08 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> It should be built and installed only if otr itself is built and installed
>
>
> Diffs
> -----
>
> otr-proxy/config/otr-config.ui PRE-CREATION
> otr-proxy/CMakeLists.txt 6cfe999
> otr-proxy/config/CMakeLists.txt PRE-CREATION
> otr-proxy/config/kcm_ktp_chat_otr.desktop PRE-CREATION
> otr-proxy/config/otr-config.h PRE-CREATION
> otr-proxy/config/otr-config.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122692/diff/
>
>
> Testing
> -------
>
> Builds fine
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150223/be62c75e/attachment.html>
More information about the KDE-Telepathy
mailing list