Review Request 122641: Improve the Person applet itself

Martin Klapetek martin.klapetek at gmail.com
Thu Feb 19 16:39:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122641/
-----------------------------------------------------------

Review request for Telepathy.


Repository: ktp-desktop-applets


Description
-------

Changes briefly:
 * now it displays the avatar when in panel
 * does not display the actions when in panel (or not big enough)
 * does display only button without text if there's not enough room to fit the whole text
 * does switch the Flow from Left-to-Right for icons-only buttons to Top-to-Bottom for buttons with text (the text is so long that it cannot fit two buttons next to each other)
 * starts 1st action on mouse click
 * uses now expanded- and compactRepresentation thing --I'd like to further add some presence indication that would be different in both cases


Diffs
-----

  person/contents/ui/Person.qml PRE-CREATION 
  person/contents/ui/main.qml 871c1c0 

Diff: https://git.reviewboard.kde.org/r/122641/diff/


Testing
-------

Added applet to panel, I now see an avatar, clicking it starts a chat. Trying it in plasmawindowed with various sizes, actions show/hide/expand/move as supposed to.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150219/43f56fb7/attachment.html>


More information about the KDE-Telepathy mailing list