Review Request 122543: Re-use AbstractContacts generated in the KTp KPeople Data Source

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122543/#review75933
-----------------------------------------------------------

Ship it!



kpeople/datasourceplugin/im-persons-data-source.cpp
<https://git.reviewboard.kde.org/r/122543/#comment52391>

    Given that "found" is nowhere else used, wouldn't it be sufficient to just do
    
    ```if (it != m_contactVCards.constEnd()) {``` ?


- Martin Klapetek


On Feb. 12, 2015, 6:20 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122543/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 6:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Re-use the instances instead of creating them every time the cache is loaded.
> 
> 
> Diffs
> -----
> 
>   kpeople/datasourceplugin/im-persons-data-source.cpp 77cb67f 
> 
> Diff: https://git.reviewboard.kde.org/r/122543/diff/
> 
> 
> Testing
> -------
> 
> KTp Contact List plasmoid:
> 1. Open the Contact List
> 2. Go online
> 3. Go offline
> 4. Go online
> 
> It doesn't assert anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150212/9b6630d9/attachment.html>