Review Request 122453: Improve KPeople documentation, in order to become a Framework

[Martin Klapetek]

> On Feb. 6, 2015, 11:24 p.m., Martin Klapetek wrote:
> > src/widgets/persondetailsview.h, line 49
> > <https://git.reviewboard.kde.org/r/122453/diff/1/?file=347207#file347207line49>
> >
> >     --> "for which the data will be displayed"

s/data/details


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122453/#review75548
-----------------------------------------------------------


On Feb. 6, 2015, 3:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122453/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 3:14 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM and Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Adds a README.md and a metainfo.yaml.
> It also documents some classes and methods that didn't have any documentation.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt bd2cd7e 
>   src/widgets/mergedialog.h 305d07b 
>   src/widgets/persondetailsview.h 0769d51 
>   CMakeLists.txt 00177f3 
>   README.md PRE-CREATION 
>   metainfo.yaml PRE-CREATION 
>   src/CMakeLists.txt 7e01976 
>   src/duplicatesfinder_p.h 05f0063 
>   src/persondata.h 0fab902 
>   src/personsmodel.h 32dc1f5 
> 
> Diff: https://git.reviewboard.kde.org/r/122453/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass ;).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150206/9341ccc9/attachment.html>