Review Request 122428: Move private methods/slots and slots from PersonsModel to PersonsModelPrivate

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122428/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 12:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Telepathy.


Repository: libkpeople


Description
-------

Move the private methods into the p-impl. First, it's the correct thing to do. Secondly, it was pulling an awkward dependency on abstractcontact.h from the backends into a public header.


Diffs
-----

  src/CMakeLists.txt d8b4875 
  src/backends/abstractcontact.h 4d1edcd 
  src/personsmodel.h 239f4ed 
  src/personsmodel.cpp bc2bee6 

Diff: https://git.reviewboard.kde.org/r/122428/diff/


Testing
-------

Builds, tests pass, ktp-contactlist still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150206/2c20f07b/attachment.html>