Review Request 122428: Move private methods/slots and slots from PersonsModel to PersonsModelPrivate

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 4 16:54:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122428/
-----------------------------------------------------------

Review request for KDEPIM and Telepathy.


Repository: libkpeople


Description
-------

Move the private methods into the p-impl. First, it's the correct thing to do. Secondly, it was pulling an awkward dependency on abstractcontact.h from the backends into a public header.


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/122428/diff/


Testing
-------

Builds, tests pass, ktp-contactlist still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150204/d7c2cd9e/attachment.html>


More information about the KDE-Telepathy mailing list