Review Request 122422: Split backends code into a separate binary
David Edmundson
david at davidedmundson.co.uk
Wed Feb 4 14:00:28 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122422/#review75401
-----------------------------------------------------------
Ship it!
and fine with me
- David Edmundson
On Feb. 4, 2015, 12:13 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122422/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 12:13 p.m.)
>
>
> Review request for KDEPIM and Telepathy.
>
>
> Repository: libkpeople
>
>
> Description
> -------
>
> If KPeople has to become a framework, we'll need to maintain ABI.
> This patch adds a separate library so we can eventually extend the backends without comprimising KPeople adoption.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 82a987a
> src/CMakeLists.txt 7b4f951
> src/backends/CMakeLists.txt PRE-CREATION
> src/defaultcontactmonitor.cpp
> src/defaultcontactmonitor_p.h cc78afb
> src/widgets/CMakeLists.txt 016a8c5
>
> Diff: https://git.reviewboard.kde.org/r/122422/diff/
>
>
> Testing
> -------
>
> Builds. Tests run.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150204/2532b58a/attachment.html>
More information about the KDE-Telepathy
mailing list