Review Request 126353: Allow passing relative paths to the services cmake function

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 14 21:00:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126353/#review89496
-----------------------------------------------------------



src/lib/KAccountsMacros.cmake (line 1)
<https://git.reviewboard.kde.org/r/126353/#comment61250>

    This should get the same treatment I think



src/lib/KAccountsMacros.cmake (line 17)
<https://git.reviewboard.kde.org/r/126353/#comment61249>

    Since we're making it more verbose, let's include more info about the origin, eg.
    
    "Error when processing the service file $filename: ${intltool_error}"


- Martin Klapetek


On Dec. 14, 2015, 8:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126353/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 8:45 p.m.)
> 
> 
> Review request for KDEPIM and Telepathy.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> Otherwise we used to get an odd and silent warning.
> Also be more verbose when the command fails.
> 
> 
> Diffs
> -----
> 
>   src/lib/KAccountsMacros.cmake dfcb636 
> 
> Diff: https://git.reviewboard.kde.org/r/126353/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20151214/67d7c68d/attachment.html>


More information about the KDE-Telepathy mailing list