Review Request 123545: Fix crash when closing new account dialog with close button

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123545/#review79648
-----------------------------------------------------------

Ship it!


This should go in Plasma/5.3 as well.

- Aleix Pol Gonzalez


On April 28, 2015, 9:36 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123545/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 9:36 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> Connect QDialogButtonBox rejected signal to QDialog reject slot.
> 
> This fixes crash when closing add new account dialog with close button (or Alt+F4).
> 
> 
> Diffs
> -----
> 
>   plugins/kaccounts/kaccounts-ui-provider.cpp a7569cf 
> 
> Diff: https://git.reviewboard.kde.org/r/123545/diff/
> 
> 
> Testing
> -------
> 
> No longer crashes when closing the dialog with close button and then trying to open new dialog - this can be triggered just by opening Gadu-Gadu new acc dialog -> closing it with Alt+F4 and then opening it again.
> 
> However, it does not fix a crash when clicking on "Create" entry in accounts list view -> then switching to some configured account -> switch back to "Create" and try to open few new account dialogs. The crash here seems to be related to KWidgetItemDelegate (particularly to createItemWidgets), but I'm not really sure what might be wrong as widgets in createItemWidgets are created correctly without parent.
> 
> This is a warning message when closing the dialog:
> 
>     KWidgetItemDelegateEventListener::eventFilter-e : User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150428/b9bb9ead/attachment.html>