Review Request 123445: Collapse the chat applet when there are no chats open

Martin Klapetek martin.klapetek at gmail.com
Tue Apr 21 10:10:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123445/
-----------------------------------------------------------

(Updated April 21, 2015, 12:10 p.m.)


Review request for Telepathy.


Bugs: 298306
    http://bugs.kde.org/show_bug.cgi?id=298306


Repository: ktp-desktop-applets


Description (updated)
-------

Just like the Pager applet, collapse when there's nothing to show. Consistency++

Also fix the property type & name - Length -> Width, Thickness -> Height, real -> int


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/FullChatList.qml db6d420 

Diff: https://git.reviewboard.kde.org/r/123445/diff/


Testing
-------

Added to panel, takes no space, opened a chat, opened another chat, closed chat, opened another chat, closed chat, closed chat, takes no space in panel. And it resized always correctly when opening/closing.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150421/7c27223e/attachment.html>


More information about the KDE-Telepathy mailing list