Review Request 123228: Extend the unit tests to also cover merging and unmerging

Aleix Pol Gonzalez aleixpol at kde.org
Thu Apr 2 15:27:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123228/#review78414
-----------------------------------------------------------

Ship it!


Good stuff!

- Aleix Pol Gonzalez


On April 2, 2015, 5:16 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123228/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 5:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Adds more contacts and actually tests the merging and unmerging.
> 
> 
> Diffs
> -----
> 
>   autotests/fakecontactsource.cpp aab6ba7 
>   autotests/persondatatests.cpp 9b39654 
>   autotests/personsmodeltest.h 3428db7 
>   autotests/personsmodeltest.cpp 4b39f65 
> 
> Diff: https://git.reviewboard.kde.org/r/123228/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150402/555f6634/attachment.html>


More information about the KDE-Telepathy mailing list